-
Notifications
You must be signed in to change notification settings - Fork 22
ui(dashboard): update incidents icon animation to draw exclamation from top to bottom #4653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+57
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om top to bottom Co-Authored-By: Kapil Gowru <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Kapil Gowru <[email protected]>
kgowru
approved these changes
Nov 3, 2025
kgowru
approved these changes
Nov 3, 2025
Co-Authored-By: Kapil Gowru <[email protected]>
…s://git-manager.devin.ai/proxy/github.com/fern-api/fern-platform into devin/1761941386-incidents-icon-draw-animation
Co-Authored-By: Kapil Gowru <[email protected]>
kgowru
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update incidents icon animation to draw exclamation sequentially
Replaced the shake animation on the incidents icon with a draw animation that sequentially draws the exclamation line from top to bottom (0-60% of animation), then shows the dot (60-100%). Animation completes in 0.3s.
What was the motivation & context behind this PR?
User requested in Slack to change the incidents icon animation from shaking on hover to drawing the exclamation mark sequentially. The SVG was also updated to a new design provided by the user. After initial implementation, the user requested speed adjustments (0.8s → 0.5s → 0.3s).
Slack thread: https://buildwithfern.slack.com/archives/C09NRQ471UK/p1761941230058009?thread_ts=1761941230.058009
How has this PR been tested?
Review checklist - IMPORTANT
Must verify visually:
3.125was calculated mathematically from the path coordinates but may not match the actual rendered path length. Watch for:prefers-reduced-motionproperly disables the animationTechnical changes:
AlertIconAnimatedcomponent to use new SVG structure with separate paths for triangle, exclamation line, and dotalert-draw-linekeyframe animation using stroke-dasharray/stroke-dashoffsetalert-show-dotkeyframe animation using opacity.alertto.alert-lineand.alert-dotLink to Devin run: https://app.devin.ai/sessions/59f25a7775e048cbad54c2a0d05cbba7
Requested by: Kapil Gowru ([email protected]) (@kgowru)